Allow interactive dismissal of VCs that need custom first responder handling #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
reviewed
Jan 25, 2025
There was a problem hiding this comment.
in general, i think, the added functionality, of being able to swipe-down-to-close the file-and gallery-view-controller as expected is worth the complexity. thanks a lot for diving into that and checking out options!
it is incredible, that this complexity is needed, but well, if there is no standard way, then it's that.
issues:
- for the app-selector, swipe-down-to-close is still not working - is that expected?
- the camera lost the swipe down functionality - is that expected?
also, i would like to hear from @zeitschlag if he would be fine with getting sth. like that in and if it is maybe better understandable by him :)
| super.viewWillDisappear(animated) | ||
| if isBeingDismissed, !lastResponders.isEmpty, let newFirstResponder = UIResponder.currentFirstResponder { | ||
| @objc fileprivate func _viewWillDisappear(_ animated: Bool) { | ||
| _viewWillDisappear(animated) |
There was a problem hiding this comment.
i do not really understand what is happening here. at a first glance, this looks to me as a recursive call, but it is not and is working as expected.
but what is then called here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some View Controllers don't give back the first responder correctly (eg when you use the search bar in UIImagePickerController). To combat this we previously wrapped those in a custom view controller that just gave back the responders manually. That sadly had the side effect of disabling interactive dismissal (swipe down to dismiss).
This PR fixes the interactive dismiss by doing away with the custom view controller wrapper and instead swizzling the methods.
Swizzling is a bit controversial but it is used by Firebase which is in many apps, and the associated objects usage is already in our app because SDWebImage uses it too.